Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable viewer frame capture in Metal #1297

Conversation

Morteeza
Copy link
Contributor

@Morteeza Morteeza commented Mar 20, 2023

Fixes #1295

Copy link
Contributor

@kwokcb kwokcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Can you do a check when the capture is done from command line. This should
be what's done as part of the CI workflow. Thanks.

@Morteeza
Copy link
Contributor Author

Thanks @kwokcb . I tested it through command line and it works fine 👍

@jstone-lucasfilm jstone-lucasfilm changed the title Enables Metal MaterialXView to capture and save current view to disk … Enable viewer frame capture in Metal Mar 21, 2023
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Morteeza!

@jstone-lucasfilm jstone-lucasfilm merged commit b6c7e50 into AcademySoftwareFoundation:main Mar 21, 2023
krohmerNV pushed a commit to krohmerNV/MaterialX that referenced this pull request Apr 5, 2023
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash trying to capture frame in MaterialXView (Mac)
3 participants