Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the 3-way comparison in tests_to_html.py #1416

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

krohmerNV
Copy link
Contributor

Tried to do a comparison between MDL 1.6, 1.7, and 1.8 and found two issues:

  • the computed file paths are not correct when passing different --inputdir1, --inputdir2, and --inputdir3
  • when comparing basically mdl against mdl and mdl, the file names of the diff images collide

@jstone-lucasfilm
Copy link
Member

@krohmerNV I like the idea of this improvement, though in my local tests it seems to break the simpler two-way comparisons between GLSL and OSL:

TwoWayComparison

@krohmerNV
Copy link
Contributor Author

I'll investigate, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants