Version information for MaterialX dlls #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGamache-autodesk
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
This looks like a good change to me, thanks @ashwinbhat!
From the perspective of visual clarity, the one change that I would suggest is to add a newline after the initial set(MATERIALX_MODULE_NAME ...) at the beginning of each CMakeLists.txt file. This should help in setting this common setup apart from the module-specific logic that follows it in each file.
JGamache-autodesk
approved these changes
Aug 17, 2023
jstone-lucasfilm
approved these changes
Aug 17, 2023
jstone-lucasfilm
merged commit 19eb023
into
AcademySoftwareFoundation:main
13 checks passed
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.