Fix scroll wheel interaction across graph editor windows #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where using the scroll wheel will both zoom in the renderview as well as the panel bar. This is done by doing a cursor bounds check and disabling scrolling for the panel if the cursor is inside the renderview.
|
This looks very promising, thanks @HudsonHN, and I'm CC'ing @lfl-eholthouser for her knowledge of this section of the codebase. |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
lfl-eholthouser
approved these changes
Nov 3, 2023
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Nov 3, 2023
jstone-lucasfilm
merged commit f086b86
into
AcademySoftwareFoundation:main
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1214
Fixed scroll wheel causing both the renderview to zoom as well as the property editor to scroll.
This is done by moving the renderview cursor bounds check up on the call stack and adding flags to disable scrolling for the property editor if the cursor is within the renderview.