Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard input affecting panels regardless of focus #1596

Open
wants to merge 19 commits into
base: dev_1.39
Choose a base branch
from

Conversation

HudsonHN
Copy link
Contributor

@HudsonHN HudsonHN commented Nov 7, 2023

Changed IsWindowFocused flags for inputs mentioned in #1424 to prevent all panels from responding.

HudsonHN and others added 8 commits October 19, 2023 03:25
Fixed the issue where using the scroll wheel will both zoom in the renderview as well as the panel bar.
This is done by doing a cursor bounds check and disabling scrolling for the panel if the cursor is inside the renderview.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Changed IsWindowFocused flags for inputs mentioned in AcademySoftwareFoundation#1424 to prevent all panels from responding.
source/MaterialXGraphEditor/Graph.cpp Outdated Show resolved Hide resolved
@jstone-lucasfilm
Copy link
Member

@HudsonHN It would be great if we can include this improvement in MaterialX 1.39, which is scheduled for release this summer. Would you mind retargeting your pull request to the dev_1.39 branch, so that we can consider your change in that context?

@HudsonHN HudsonHN changed the base branch from main to dev_1.39 March 15, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants