New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard input affecting panels regardless of focus #1596
Open
HudsonHN
wants to merge
19
commits into
AcademySoftwareFoundation:dev_1.39
Choose a base branch
from
HudsonHN:main
base: dev_1.39
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where using the scroll wheel will both zoom in the renderview as well as the panel bar. This is done by doing a cursor bounds check and disabling scrolling for the panel if the cursor is inside the renderview.
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Changed IsWindowFocused flags for inputs mentioned in AcademySoftwareFoundation#1424 to prevent all panels from responding.
eytienne
suggested changes
Nov 17, 2023
@HudsonHN It would be great if we can include this improvement in MaterialX 1.39, which is scheduled for release this summer. Would you mind retargeting your pull request to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed IsWindowFocused flags for inputs mentioned in #1424 to prevent all panels from responding.