Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null check in Graph::propertyEditor #1601

Conversation

eytienne
Copy link
Contributor

Fixes #1600

Copy link

linux-foundation-easycla bot commented Nov 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jstone-lucasfilm
Copy link
Member

This looks very promising, thanks @eytienne! I'm CC'ing @lfl-eholthouser for her thoughts on the proposed fix.

Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
@jstone-lucasfilm jstone-lucasfilm changed the title Fixed null check in Graph::propertyEditor() Fixed null check in Graph::propertyEditor Nov 21, 2023
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @eytienne!

@jstone-lucasfilm jstone-lucasfilm merged commit 60c8a59 into AcademySoftwareFoundation:main Nov 21, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in Graph::propertyEditor due to absence of null check
3 participants