Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UI attributes in web viewer #1623

Merged

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Dec 22, 2023

Changes

  • ui min, max, step support for property editor inputs
  • label ui advanced folders
  • enable complete vs reduced to get exposure of consistent inputs as with other utils.
  • fix nodedef input lookup to handle non-root nodes
  • use x,y,z,w for vector input names vs full name and ".0".

Results:

  • Slider update and advanced tagging
    image

  • Proper set of inputs for upstream nodes
    image

  • Vector UI naming:
    image

  • No sliders for enumerations (Leave "TODO" to add drop-drowns for now)
    image

- enable complete vs reduced to get exposure of consistent inputs as with other utils.
@kwokcb kwokcb mentioned this pull request Dec 22, 2023
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @kwokcb!

@jstone-lucasfilm jstone-lucasfilm changed the title WebViewer: Add support for UI attributes Add support for UI attributes in web viewer Dec 22, 2023
@jstone-lucasfilm jstone-lucasfilm merged commit 5bd76a8 into AcademySoftwareFoundation:main Dec 22, 2023
31 checks passed
@kwokcb kwokcb deleted the webiewer_range_support branch January 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants