Upgrade switch node to ten inputs in 1.39 #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld-kerley
changed the title
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
This looks good to me, @ld-kerley, and I'm CC'ing @dbsmythe and @niklasharrysson for their thoughts on this alignment of our codebase with the specification.
niklasharrysson
approved these changes
Jan 28, 2024
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit f4c84a6
into
AcademySoftwareFoundation:dev_1.39
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added an upgrade function, which may need some closer attention. The upgrade function attempts to retain the behavior from 1.38 where any value of
whichthat is above the accepted range that would previously been served the default (in1) value. Awhichvalue of 6 would have previously returnin1, but now it would return one of the newly added inputs. To retain the previous renderer image, the document upgrader sets the value ofwhichto the default of 0.I'm very much open to input if this doesn't feel right.