Add Gooch Shading node to NPR library #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libraries/nprlib/nprlib_defs.mtlx # libraries/nprlib/nprlib_ng.mtlx
There was a problem hiding this comment.
This looks like a great start, thanks @kwokcb and @ashwinbhat, and I had a few initial notes on interface conventions and categorization.
Improve input names
Ensure highlight is affected by light_direction instead of viewDirection
- Fix warm and cool colours (was swapped)
… Gooch98 paper. Any warm or cool colour computation could be connected.
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 7bec19f
into
AcademySoftwareFoundation:main
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of a
goochnode to the NPR data library that represents Gooch Shading used for technical illustration. This is built on prior work by @bernardkwok