Fix Python binding of setUnitType #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix, @msuzuki-nvidia! Now that we're focusing on MaterialX 1.39 development in preparation for SIGGRAPH 2024, we're aiming to make all new changes to the https://github.com/AcademySoftwareFoundation/MaterialX/tree/dev_1.39 Would it be possible to reframe your pull request as a change to the |
|
@jstone-lucasfilm sure thing. changed target to |
jstone-lucasfilm
approved these changes
Mar 6, 2024
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit fe99673
into
AcademySoftwareFoundation:dev_1.39
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python API
setUnitType()was bound to C++hasUnitType().This issue was initially reported here:
https://academysoftwarefdn.slack.com/archives/C0230LWBE2X/p1702146955156999