Losslessly optimize PNG and JPG files #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this proposal together, @C0rn3j! Since we're currently focusing development efforts on MaterialX 1.39, would you mind targeting this pull request to the |
|
@jstone-lucasfilm First time doing so, hope this does it |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
May 26, 2024
jstone-lucasfilm
merged commit 7f3141f
into
AcademySoftwareFoundation:dev_1.39
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used oxipng, jpegoptim, svgo.
Shouldn't change anything compatibility wise, optimizations are lossless. SVGs aren't, which shouldn't be a problem unless metadata is somehow used.
EXIF in JPEG/PNG was left intact.
Detailed commands that were ran as per https://rys.rs/optimization