Improve Robustness of Input Connection Setting #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move the value attribute. Add new unit test case, and fix invalid color management test case.
|
@JGamache-autodesk, @zicher3d. I believe the change should address both the lack of validation and make the interface more robust in general and in the node editor. |
kwokcb
commented
Apr 10, 2024
| @@ -1869,7 +1869,6 @@ void Graph::copyInputs() | |||
| } | |||
|
|
|||
| copyNode->inputPins[count]->setConnected(true); | |||
| copyNode->inputPins[count]->_input->removeAttribute(mx::ValueElement::VALUE_ATTRIBUTE); | |||
There was a problem hiding this comment.
Just removing the value can actually leave a state of no value and no connection.
resources/Materials/TestSuite/stdlib/color_management/color_management.mtlx
Show resolved
Hide resolved
JGamache-autodesk
approved these changes
Apr 10, 2024
kwokcb
changed the title
JGamache-autodesk
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This change adds detection for the case where both a connection and a value are specified, adds and update connection APIs to enforce not creating invalid documents.
Changes
Input::setInterfaceInput()interface which clears thevalueattributes to avoid accidently creating invalid documents.valueattribute appropriately.mxvalidate.pyto be able to handle a folder as input.Tests
color_management.mtlx).mxvalidate.pyand code generation tests caught this error. Ranmxvalidateon everything inlibrariesandresources.nodeunit test to check interface setting and validity checking.valueandinterfacenameclearing calls.