Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix type switch nodes #1779

Conversation

ld-kerley
Copy link
Contributor

  • ND_switch_matrix33
  • ND_switch_matrix44
  • ND_switch_matrix33I
  • ND_switch_matrix44I

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks @ld-kerley, and I'm CC'ing @krohmerNV and @dbsmythe for their thoughts on the MDL implementation and specification revisions.

@jstone-lucasfilm jstone-lucasfilm merged commit 5c55def into AcademySoftwareFoundation:dev_1.39 Apr 22, 2024
31 checks passed
@ld-kerley ld-kerley deleted the switch_matrix_nodes branch April 22, 2024 23:37
@krohmerNV
Copy link
Contributor

@jstone-lucasfilm this will probably not compile with MDL 1.6 and 1.7 because the stdlib_1_6.mdl needs the definitions too (or it should be there only).. anyhow I'll fix this as soon as I can.

But a general question. Isn't it possible to implement the switch in mtlx directly using a graph? this hard-coded number of options doesn't look nice.

@jstone-lucasfilm
Copy link
Member

@krohmerNV Thanks for the catch, and it's a good reminder that we still want to integrate MDL shader validation into our GitHub Actions tests.

If there's an efficient graph-based implementation of switch, we'd definitely be open to that improvement, and it would reduce the dependence on language-specific implementations.

@ld-kerley
Copy link
Contributor Author

@krohmerNV - are the additions you're suggesting are needed to stdlib_1_6.mdl in this PR already - here ?

Or are other changes needed?

@krohmerNV
Copy link
Contributor

@ld-kerley, you are right. That's what I meant. Sorry.
I'll check locally to verify and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants