Remove swizzle node for 1.39 #1793
Conversation
This changelist removes the swizzle node from the MaterialX data libraries for v1.39, adding an upgrade pathway for instances of this node in legacy documents. Additionally, it addresses a minor inconsistency in the specification for the extract and extractrowvector nodes, which take zero-based indices rather than positive-valued selections.
|
Attaching updated comparison renders in GLSL and OSL: |
jstone-lucasfilm
merged commit a05410a
into
AcademySoftwareFoundation:dev_1.39
|
can we also completely remove |
|
@ld-kerley Absolutely, and there's a dedicated file in the MDL shader generation system that can now be removed as well, but I'm taking this change in stages! |
| { | ||
| InputPtr inInput = node->getInput("in"); | ||
| InputPtr channelsInput = node->getInput("channels"); | ||
| if (inInput && |
There was a problem hiding this comment.
Do you need to handle the case where inInput doesn't exist? All the node defs appear to return 0, but it's possible the swizzle node was wired in to a port that doesn't have 0 as its default?
There was a problem hiding this comment.
That's a good point, and perhaps we should handle this case by converting the swizzle node to a constant node containing the appropriate values. I haven't encountered this case in our test assets, but it's theoretically possible.
This changelist removes the swizzle node from the MaterialX data libraries for v1.39, adding an upgrade pathway for instances of this node in legacy documents.
Additionally, it addresses a minor inconsistency in the specification for the extract and extractrowvector nodes, which take zero-based indices rather than positive-valued selections.