Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for EON diffuse #1822

Merged
merged 14 commits into from
May 23, 2024
Merged

Initial support for EON diffuse #1822

merged 14 commits into from
May 23, 2024

Commits on May 19, 2024

  1. Initial support for EON diffuse 

    This changelist adds initial support for the EON diffuse model in MaterialX, enabled through the use of an energy_compensation flag on the oren_nayar_diffuse_bsdf node.

For now, only GLSL/ESSL/MSL support the new functionality in MaterialX shader generation, with other shading languages to be added once this initial implementation has been vetted by the community.

See the OpenPBR whitepaper at openpbr.org for full details on the EON diffuse model, including its formal definition and goals.
    @jstone-lucasfilm
    jstone-lucasfilm committed May 19, 2024
    Configuration menu
    Copy the full SHA
    bb08fce View commit details
    Browse the repository at this point in the history

  2. Mark energy_compensation as uniform

    @jstone-lucasfilm
    jstone-lucasfilm committed May 19, 2024
    Configuration menu
    Copy the full SHA
    83332f5 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Update to Fujii constants

    @jstone-lucasfilm
    jstone-lucasfilm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    dbce25a View commit details
    Browse the repository at this point in the history

  2. Remove extra newline 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm committed May 20, 2024
    Configuration menu
    Copy the full SHA
    55636f0 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Minor rename for clarity

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1892eec View commit details
    Browse the repository at this point in the history

  2. Remove extra cast

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    929b04f View commit details
    Browse the repository at this point in the history

  3. Add parentheses for clarity

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7c55526 View commit details
    Browse the repository at this point in the history

  4. Clarify comments

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f535032 View commit details
    Browse the repository at this point in the history

  5. Additional clarifications to comments

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    57b0cae View commit details
    Browse the repository at this point in the history

  6. Remove qualifiers on float literals

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d5e3505 View commit details
    Browse the repository at this point in the history

  7. Clarify math

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b4c7c92 View commit details
    Browse the repository at this point in the history

  8. Improvements to indirect diffuse

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    376a5f4 View commit details
    Browse the repository at this point in the history

  9. Remove unneeded line

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    186e053 View commit details
    Browse the repository at this point in the history

  10. Simplify variable names

    @jstone-lucasfilm
    jstone-lucasfilm committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e2004de View commit details
    Browse the repository at this point in the history