Support for exporting metadata in shader generation (#371) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add implemention of AttributeDef element. * Added AttributeDef pointer types * Support [[ ]] punctuations for scope begin/end. * Fixed issue with boolean type in OSL. * Add metadata to ShaderPort. Support generation of metadata for shader inputs. * Added AttributeDef methods to document. * Fixed bug with scope handling in shader generation * Using AttributeDefs for registering shader metadata. * Support for metadata on node level. * Added unittest for metadata generation. * Fix typo in standard_surface nodedef. * Support input widget metadata. * Code cleanup. * Fix initialization order issue.
niklasharrysson
commented
May 25, 2020
|
|
||
| /// @class GenUserData | ||
| /// Base class for custom user data needed during shader generation. | ||
| class GenUserData : public std::enable_shared_from_this<GenUserData> |
There was a problem hiding this comment.
Moved out to a separate file.
niklasharrysson
commented
May 25, 2020
| /// Derived shader generators may override this method to change the registration. | ||
| /// Applications must explicitly call this method before shader generation to enable | ||
| /// export of metadata. | ||
| virtual void registerShaderMetadata(const DocumentPtr& doc, GenContext& context) const; |
There was a problem hiding this comment.
Calling this method on the GenContext will enable export for shader metadata, according to which attributedefs are defined and/or which metadata this shader generator allows if the method is overridden.
|
Looks good, thanks @niklasharrysson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list adds support for exporting shader metadata in shader generation, as well as addresses a couple of other issues: