PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. #100

KelSolaar · 2023-06-18T19:48:59Z

This PR implements support for the remaining DisplayP3 colourspaces and many other features.

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar · 2023-07-05T17:40:03Z

@doug-walker: I opened a PR (ampas/aces-dev#136) to add support for DisplayP3 on the aces-dev side and updated the spreadsheets accordingly. We are missing a Builtin on the OCIO side which is alright but it begs the question as to whether the Builtin should be in https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/src/OpenColorIO/transforms/builtins/ACES.cpp or not given the PR is not merged at all, and might not be in time.

KelSolaar · 2023-07-26T09:29:49Z

PR was merged, we can move on! A few notes:

We will use this PR for most of the new release features as it is simple.
Because the next release of OCIO and the future Pypi wheels depend on the config generated by this PR but this PR cannot require non-existing wheels, we have decided to manually build the configs for the next release of OCIO rather than doing it on CI. This will be done once the wheels are available.

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar · 2023-09-02T09:05:02Z

Ok this is ready, I verified that the artefacts generated are producing the same files than the builtin configs in 2.3!

@michdolan and @doug-walker for VIS!

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

doug-walker

LGTM, thank you Thomas!

doug-walker · 2023-09-10T19:51:11Z

opencolorio_config_aces/clf/transforms/arri/input/ARRI.Input.ARRI_LogC4_to_ACES2065-1.clf

@@ -3,7 +3,7 @@
    <InputDescriptor>ARRI LogC4</InputDescriptor>
    <OutputDescriptor>ACES2065-1</OutputDescriptor>
    <Info>
-        <ACEStransformID>urn:ampas:aces:transformId:v1.5:IDT.ARRI.LogC4.a1.v1</ACEStransformID>
+        <ACEStransformID>urn:ampas:aces:transformId:v1.5:IDT.ARRI.ARRI-LogC4.a1.v1</ACEStransformID>


Given that we are modifying the ID submitted by Sean of ARRI, should we do anything to indicate this was to make it agree with what is in aces-dev? Should we get Sean to approve it? Or maybe it's sufficiently obvious that it's just a bug fix and no comment is necessary. Either way is fine with me.

Will add a comment, thank you!

Will add a comment in the release notes as it gives better visibility.

KelSolaar added 2 commits June 18, 2023 21:32

Implement support for "Ruff".

bbea48c

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Add "opencolorio_config_aces.utilities.ROOT_BUILD_DEFAULT" attribute.

8b0bbc9

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar mentioned this pull request Jun 20, 2023

Adding P3-D65 (aka DisplayP3) gamut support #97

Closed

KelSolaar added 3 commits June 23, 2023 08:20

Fix incorrect spreadsheet url in documentation.

87a1556

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Implement support for "sRGB Encoded P3-D65 - Texture" space.

66b23e2

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Implement support for inverse "LMT" discovery.

e648216

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar changed the title ~~PR: Implement Support for Remaining DisplayP3 Colourspaces~~ PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. Jul 26, 2023

KelSolaar added 2 commits July 28, 2023 21:40

Implement support for "DisplayP3" colourspace.

69c40aa

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Implement support for missing "Canon" colourspaces.

bf8bed9

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch 2 times, most recently from d900e5c to 12eabed Compare July 28, 2023 10:27

Fix inexact reference to "D60" whitepoint.

a84d6fa

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from 12eabed to 944cb21 Compare July 28, 2023 10:29

Implement support for missing "Sony" colourspaces.

c65cbc2

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from 944cb21 to 6e6fa88 Compare July 30, 2023 08:01

KelSolaar added 3 commits July 30, 2023 20:04

Update matte_paint and texture_paint roles.

e465c90

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update various docstrings.

cfe8066

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update broken doctests.

181df7c

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from 6e6fa88 to 181df7c Compare July 30, 2023 08:04

KelSolaar added 4 commits July 31, 2023 21:04

Add "texture" categorie to "Raw" colourspace.

1c9b530

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update config mapping files.

c2020e6

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update various colourspace names and aliases.

7c32d15

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Extract tag only from "aces-dev" version.

55274e5

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from ecf907b to dbc462e Compare August 12, 2023 02:27

KelSolaar marked this pull request as ready for review August 12, 2023 02:31

KelSolaar force-pushed the feature/displayp3 branch from dbc462e to 2703bcf Compare August 17, 2023 06:47

Update config mapping files.

f9e9003

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from 2703bcf to 3d0f913 Compare August 19, 2023 04:55

KelSolaar force-pushed the feature/displayp3 branch 4 times, most recently from 011234a to f05b3b8 Compare August 19, 2023 21:53

Implement initial support for "AMF" components.

ccf11e8

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from f05b3b8 to ccf11e8 Compare August 19, 2023 21:58

KelSolaar added 3 commits August 22, 2023 17:00

Update various "CLF" descriptions.

d824a2e

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update "requirements.txt" file.

e78a168

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Remove "Reference" role in "Reference" config.

73b2581

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from e69b829 to 73b2581 Compare September 1, 2023 20:13

KelSolaar added 4 commits September 2, 2023 08:14

Update supported "OpenColorIO" profile list.

75bff19

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Implement support for shorter config description.

e4fcd0c

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Code formatting.

db2064c

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Update various docstrings.

1025589

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch 4 times, most recently from 69f8d8d to 4c1dd57 Compare September 2, 2023 08:49

KelSolaar added 2 commits September 2, 2023 20:57

Overhaul "pyproject.toml" file.

5dcd517

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

Improve dependency versions support.

e0a7c15

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar requested review from michdolan and doug-walker September 2, 2023 09:04

Update "README.rst" file.

39e5e48

Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>

KelSolaar force-pushed the feature/displayp3 branch from 4c1dd57 to 39e5e48 Compare September 5, 2023 07:26

doug-walker approved these changes Sep 10, 2023

View reviewed changes

KelSolaar merged commit 10a851a into AcademySoftwareFoundation:main Sep 16, 2023
9 checks passed

KelSolaar deleted the feature/displayp3 branch September 16, 2023 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. #100

PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. #100

KelSolaar commented Jun 18, 2023 •

edited

KelSolaar commented Jul 5, 2023

KelSolaar commented Jul 26, 2023

KelSolaar commented Sep 2, 2023

doug-walker left a comment

doug-walker Sep 10, 2023 •

edited

KelSolaar Sep 12, 2023 •

edited

KelSolaar Sep 16, 2023

PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. #100

PR: Implement Support for Remaining DisplayP3 Colourspaces, and Other Next Release Features. #100

Conversation

KelSolaar commented Jun 18, 2023 • edited

KelSolaar commented Jul 5, 2023

KelSolaar commented Jul 26, 2023

KelSolaar commented Sep 2, 2023

doug-walker left a comment

Choose a reason for hiding this comment

doug-walker Sep 10, 2023 • edited

Choose a reason for hiding this comment

KelSolaar Sep 12, 2023 • edited

Choose a reason for hiding this comment

KelSolaar Sep 16, 2023

Choose a reason for hiding this comment

KelSolaar commented Jun 18, 2023 •

edited

doug-walker Sep 10, 2023 •

edited

KelSolaar Sep 12, 2023 •

edited