PR: Aliases, NamedTransform, Base Config Inheritance #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
…rspace_factory" definition. Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
…use an existing base configuration. Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
michdolan
approved these changes
Aug 31, 2021
doug-walker
approved these changes
Sep 1, 2021
|
Thanks, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for:
opencolorio_config_aces.colorspace_factorydefinition.NamedTransformcreation via theopencolorio_config_aces.named_transform_factorydefinition.opencolorio_config_aces.generate_configdefinition so that the config can be generated from an existing config, e.g. ACES 1.2 config.The important milestone is that it is the first time I'm using the repository and the exposed API to generate custom configs at work. It is quite neat and I managed to remove a lot of our custom code!
I will see if I can put together a small example on how to programmatically modify the ACES 1.2 config.