Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between v1 GPU path and v2 Legacy GPU Path #1294

Closed
est77 opened this issue Jan 28, 2021 · 6 comments
Closed

Differences between v1 GPU path and v2 Legacy GPU Path #1294

est77 opened this issue Jan 28, 2021 · 6 comments
Assignees

Comments

@est77
Copy link

est77 commented Jan 28, 2021

While trying to update an app using OCIO v1 to OCIO v2 I found some differences in the GPU path transforms between the 2 versions when applying the transforms to HDR images. CPU transforms match.

I am using OpenColorIO v2.0.0-rc1 with the ACES 1.0.3 config. Same config in both versions.

V1 CPU:
image

V2 CPU:
image

V1 GPU:
image

V2 Legacy GPU:
image

Thanks!

@est77
Copy link
Author

est77 commented Feb 9, 2021

I updated my app to use the final v2.0 release and I can confirm that the clamping is still present in the GPU legacy engine (the one that bakes all transforms into a single 3d LUT).

@chrisbrejon
Copy link
Contributor

Yeah same thing here. We have the exact same behavior in our render view.
Thanks !

@remia
Copy link
Collaborator

remia commented Feb 10, 2021

I think the allocation / allocationvars are lost after optimization (even with optimization == none as they are no-op) so that when extractGpuShaderInfo try to query them in PartitionGPUOps to add the appropriate shaper in the shader nothing is left to see.

I can confirm that when using ociodisplay and trying to apply a ACES2065-1 to ODT - sRGB transform (ACES Config 1.2), the shader generated for gpulegacy doesn't have any log shaper and that's not correct.

@chrisbrejon
Copy link
Contributor

Thanks Remi ! You rock !

@doug-walker
Copy link
Collaborator

doug-walker commented Feb 10, 2021

Hi Remi, thanks. Yes, Patrick and I are aware of the problem. We have a PR in progress.

Though, as an aside, if anyone is implementing their GPU path using "legacy" mode, they are missing out on one of the best features of v2. We will fix this, but we definitely do not recommend this way of working.

@est77
Copy link
Author

est77 commented Feb 11, 2021

Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants