Adsk Contrib - Better manage Imath dependency #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
commented
Sep 2, 2021
|
I did my tests on |
|
The PR is a candidate for RB-2.1 |
Signed-off-by: hodoulp <Patrick.Hodoul@autodesk.com>
remia
reviewed
Sep 7, 2021
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Merged
doug-walker
approved these changes
Sep 8, 2021
hodoulp
added a commit
that referenced
this pull request
Sep 8, 2021
* Adsk Contrib - Better manage Imath dependency Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Add the OpenImageIO_Util dependency to OSL unit test framework Signed-off-by: hodoulp <Patrick.Hodoul@autodesk.com> * Fix oiio typo Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Sep 21, 2021
* Adsk Contrib - Better manage Imath dependency Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Add the OpenImageIO_Util dependency to OSL unit test framework Signed-off-by: hodoulp <Patrick.Hodoul@autodesk.com> * Fix oiio typo Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com
Using
Imathin the library could sometime conflict with theImathfromOpenImageIO. When you try on ubuntu 20.04 using the systemOpenImageIOthe compilation ofOpenColorIOfails because of symbol clashes onImath(i.e. 3.1.x from OpenColorIO 2.1.x vs. 3.0.x expected by OpenImageIO 2.1.x).The pull request changes the code to use the OpenImageIO one for apps using OpenImageIO. I also removed some useless
Imathdependencies.