Adsk Contrib - Fix some weaknesses in the search path validation #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
remia
approved these changes
Nov 8, 2021
|
The pull request is now ready to merge (25 days old). I will merge it in 1 - 2 days. |
doug-walker
approved these changes
Dec 1, 2021
hodoulp
added a commit
that referenced
this pull request
Dec 6, 2021
* Adsk Contrib - Fix some weaknesses in the search path validation Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations, part II Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Dec 7, 2021
* Adsk Contrib - Fix some weaknesses in the search path validation Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations, part II Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Dec 7, 2021
…) (#1545) * Adsk Contrib - Fix some weaknesses in the search path validation Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations, part II Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Dec 10, 2021
* Adsk Contrib - Fix some weaknesses in the search path validation Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations, part II Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
added a commit
that referenced
this pull request
Dec 10, 2021
…) (#1552) * Adsk Contrib - Fix some weaknesses in the search path validation Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com> * Fix the Windows path in the unit test validations, part II Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul Patrick.Hodoul@autodesk.com
The pull request fixes the issue #1456 i.e. not stop at the first unresolved search path.
The search path validation now loops over all the search paths before triggering or not an error, and the unit tests now validates much more use cases. The test
context_variable_with_search_path_v2demonstrates that the issue is now fixed (i.e. from line 1559 to line 1591).Also tested using the python bindings (like described in the issue):