Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python source distribution package #1605

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

remia
Copy link
Collaborator

@remia remia commented Feb 23, 2022

Adding Python source distribution package to be uploaded to PyPI, allowing source install (eg. when a binary wheel for the requested architecture is not available) as discussed in #1573.

I pushed a test PyPI archive to test, available here. Download and then call pip install on it to test, there is a way to test that directly installing from pip / test.pypi.org but there are security concerns as dependency can be pulled from test PyPI which we can't trust so I won't share the command here.

Signed-off-by: Rémi Achard <remiachard@gmail.com>
Signed-off-by: Rémi Achard <remiachard@gmail.com>
Copy link
Member

@hodoulp hodoulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm clearly not an expert. As @remia did a test I approve the PR.

@hodoulp
Copy link
Member

hodoulp commented Mar 11, 2022

Friendly reminder that the pull request could now be merged next week (i.e. more than two-weeks old).

Copy link
Collaborator

@doug-walker doug-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remi!

@doug-walker doug-walker merged commit 415c583 into AcademySoftwareFoundation:main Mar 19, 2022
@remia remia added this to the OCIO 2.2.0 milestone Apr 6, 2022
@doug-walker doug-walker added this to Done in v2.2 planning Apr 13, 2022
@remia remia deleted the python-source-dist branch April 27, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants