Port from main to RB-2.1 - Backport improved "OpenImageIO" dependency management. #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remia
reviewed
Mar 9, 2022
KelSolaar
changed the title
remia
reviewed
Mar 10, 2022
There was a problem hiding this comment.
Thanks for the update @KelSolaar.
I believe we should also remove the find_package(OpenImageIO ...) from here.
hodoulp
suggested changes
Mar 11, 2022
Signed-off-by: Thomas Mansencal <thomas.mansencal@gmail.com>
remia
approved these changes
Mar 17, 2022
hodoulp
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR backports ec50ccb from @hodoulp to 2.1 to make sure that the
Imathheaders are included as dependencies while building the OCIO apps.@remia for VIS.
Cheers,
Thomas