Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk contrib - Add Built-in Transforms for ARRI LogC4 and Canon curves #1704

Conversation

doug-walker
Copy link
Collaborator

Adds Built-in Transforms for:
-- ARRI LogC4
-- Canon Log2 curve
-- Canon Log3 curve

I verified that the CLF file exported from the Built-in Transform for LogC4 matches the CLF that was recently added to the OpenColorIO-Config-ACES repo for the Studio config.

The Canon curves are implemented as a normal domain rather than half-domain Lut1D based on the preference received from Canon during the development of the Studio config. (The shape of the curves currently precludes implementing them as a LogCameraTransform.)

Implements Issue #1686.

Signed-off-by: Doug Walker doug.walker@autodesk.com

Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
@remia
Copy link
Collaborator

remia commented Oct 24, 2022

Missed that earlier, but is there some update related to config version checks about the use of the newly introduced builtin transforms? Similar to what is done here or here for the RGC.

@doug-walker
Copy link
Collaborator Author

doug-walker commented Oct 24, 2022

Excellent question @remia ! No updates are needed on the CTF side since Builtin Transforms are not actually saved in CTF, they are expanded first. (And actually I should log a feature request for that since we ran into a use for that on the configs working group.) However, I should update checkVersionConsistency in Config.cpp and will push another commit to do that.

Please note that the new tests will fail until PR #1702 is merged so that version 2.2 configs may be parsed.

Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
@doug-walker doug-walker merged commit 5dc32f9 into AcademySoftwareFoundation:main Oct 27, 2022
@doug-walker doug-walker deleted the adsk_contrib/add_builtins branch October 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants