Adsk Contrib - Adding support for ocio://cg-config-latest and ocio://studio-config-latest #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…test Added unit tests that covers the new names. CreateFromBuiltinConfig now supports the URI interface directly as well. Previously, it was supporting only the built-in config name (not a URI). The config name was parsed out of the URI before passing it to CreateFromBuiltConfig by CreateFromFile. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Tweaking unit tests Other minor changes Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Adding missing type in PyTypes.cpp Change name of constexpr to follow the others in OCIO (all in capital) Moved them to the cpp file since they can be useful in tests Comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…' that was brought up with Clang under Linux and macos. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
remia
reviewed
Mar 7, 2023
… release. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
remia
approved these changes
Apr 3, 2023
zachlewis
approved these changes
May 4, 2023
Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
zachlewis
approved these changes
May 24, 2023
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
doug-walker
approved these changes
Aug 25, 2023
brkglvn01
pushed a commit
to brkglvn01/OpenColorIO
that referenced
this pull request
Oct 23, 2023
…studio-config-latest (AcademySoftwareFoundation#1773) * Added ResolveConfigPath function Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Added support for ocio://cg-config-latest and ocio://studio-config-latest Added unit tests that covers the new names. CreateFromBuiltinConfig now supports the URI interface directly as well. Previously, it was supporting only the built-in config name (not a URI). The config name was parsed out of the URI before passing it to CreateFromBuiltConfig by CreateFromFile. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Documentations and typos Tweaking unit tests Other minor changes Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * documentations Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Using OCIO_BUILTIN_URI_PREFIX where we can in the code (not in tests) Adding missing type in PyTypes.cpp Change name of constexpr to follow the others in OCIO (all in capital) Moved them to the cpp file since they can be useful in tests Comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * documentation Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Fixing error : ISO C++ forbids converting a string constant to 'char*' that was brought up with Clang under Linux and macos. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Remove deprecation for getDefaultBuiltinConfigName. Will wait for 2.3 release. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Fixing issue with the rebase Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com> Signed-off-by: Doug Walker <doug.walker@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Brooke <beg9562@rit.edu>
doug-walker
added a commit
to autodesk-forks/OpenColorIO
that referenced
this pull request
Dec 6, 2023
…studio-config-latest (AcademySoftwareFoundation#1773) * Added ResolveConfigPath function Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Added support for ocio://cg-config-latest and ocio://studio-config-latest Added unit tests that covers the new names. CreateFromBuiltinConfig now supports the URI interface directly as well. Previously, it was supporting only the built-in config name (not a URI). The config name was parsed out of the URI before passing it to CreateFromBuiltConfig by CreateFromFile. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Documentations and typos Tweaking unit tests Other minor changes Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * documentations Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Using OCIO_BUILTIN_URI_PREFIX where we can in the code (not in tests) Adding missing type in PyTypes.cpp Change name of constexpr to follow the others in OCIO (all in capital) Moved them to the cpp file since they can be useful in tests Comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * documentation Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Fixing error : ISO C++ forbids converting a string constant to 'char*' that was brought up with Clang under Linux and macos. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Remove deprecation for getDefaultBuiltinConfigName. Will wait for 2.3 release. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Fixing issue with the rebase Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Cédrik Fuoco <105517825+cedrik-fuoco-adsk@users.noreply.github.com> Signed-off-by: Doug Walker <doug.walker@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com> Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new special names for the built-in configs. The two special names are:
cg-config-latestandstudio-config-latest.They can be used by setting the OCIO environment variables to the following:
ocio://cg-config-latestocio://studio-config-latestA new method called
ResolveConfigPathhas been added to the public API. It resolves any built-in config's special name into the actual name of the config. For example, at the moment, resolvingocio://defaultwould returnocio://cg-config-v1.0.0_aces-v1.3_ocio-v2.1. The client's application will be able to call that method to save the real built-in config path and be sure that it is going to be forward-compatible.