Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adsk contrib - Fix for dependencies workflow #1795

Conversation

cedrik-fuoco-adsk
Copy link
Contributor

@cedrik-fuoco-adsk cedrik-fuoco-adsk commented Apr 28, 2023

This is a fix for the failure in the dependencies workflow on macOS where OSL wasn't able to find the LLVM directory.

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
… in the runner

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…nges in it.

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…instead of llvm@15.

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
@cedrik-fuoco-adsk cedrik-fuoco-adsk marked this pull request as ready for review April 28, 2023 17:38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to just add a check for macOS instead of creating a new file under share/ci/scripts/macos since I think that would have it duplicated the code for no good reason and that the changes were only to add some CMAKE variables. I would have created a file under the macOS section if it was a completely new logic.

@cedrik-fuoco-adsk cedrik-fuoco-adsk changed the title Adsk contrib - Tentative fix for dependencies workflow Adsk contrib - Fix for dependencies workflow May 1, 2023
Copy link
Collaborator

@remia remia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedrik-fuoco-adsk Just noting, in case that helps, you can run the workflow as part of the PR by introducing a dummy change to the GHA workflow file because we have a trigger here. Also, haven't tested but there is now a vscode extension for GHA here.

@doug-walker doug-walker merged commit 01f2175 into AcademySoftwareFoundation:main May 2, 2023
@doug-walker doug-walker deleted the adsk_contrib/tentative-fix-for-dependencies-workflow branch May 2, 2023 18:49
@cedrik-fuoco-adsk
Copy link
Contributor Author

cedrik-fuoco-adsk commented May 2, 2023

@cedrik-fuoco-adsk Just noting, in case that helps, you can run the workflow as part of the PR by introducing a dummy change to the GHA workflow file because we have a trigger here. Also, haven't tested but there is now a vscode extension for GHA here.

Thanks @remia for the information! I did the dummy change in one of the previous commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants