-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GetProcessorFromConfigs variants for displays and views. #1808
Added GetProcessorFromConfigs variants for displays and views. #1808
Conversation
(Would be good for the library to have a |
Thanks @num3ric, sounds like a good idea to add some unit tests inspired from the existing tests on other |
There is a conflict on the branch following some recent merges in main. |
c79f7b1
to
85df1f1
Compare
Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com>
85df1f1
to
19a796c
Compare
…argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com>
7a5c4e3
to
b9ec011
Compare
Added unit tests. Also moved the direction argument last since in this case it reverses the entire chain of transforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric! No need to make any changes (the two notes are just to myself, for later).
if (!p2) | ||
{ | ||
throw Exception("Can't create the processor for the destination config " | ||
"and the destination color space."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"color space" --> "display/view"
const char * dstDisplay, | ||
const char * dstView, | ||
TransformDirection direction) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code you used as the model for this method was recently removed and replaced with GetInterchangeRolesForColorSpaceConversion. I think some refactoring will be needed later, but it's ok to reintroduce this here for now.
…mySoftwareFoundation#1808) * Added GetProcessorFromConfigs variants for displays and views. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> * Added display-view processor from two configs tests, moved direction argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> --------- Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> Co-authored-by: Michael Dolan <michdolan@gmail.com> Signed-off-by: Brooke <beg9562@rit.edu>
…mySoftwareFoundation#1808) * Added GetProcessorFromConfigs variants for displays and views. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> * Added display-view processor from two configs tests, moved direction argument last. Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> --------- Signed-off-by: Eric Renaud-Houde <eric.renaud.houde@gmail.com> Co-authored-by: Michael Dolan <michdolan@gmail.com> Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
Yield a single processor from a color space in config (a) to a display-view in config (b), through the interchange space.
Let me know if we think we need test coverage for these.