-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI build option #551
Add CI build option #551
Conversation
Any opinions on this? I'm not 100% on the option name "OCIO_CI" maybe "WERROR" makes more sense. But in practice, I still don't think its a good idea to halt compilation for other folks. Unless someone knows some easy CMake-foo to override this for your average CMake user. |
There are two parts to your concern:
|
I'm sold on your suggestion, I'll revise the PR with that |
Would it make sense to disable |
b462f4d
to
6f50ebf
Compare
6f50ebf
to
63c5800
Compare
* Add optional warning as error * reformating - whitespace removal
Seeing as how we test very few build combinations through CI, I feel its best not to completely halt compilation for someone else that is trying to build OCIO for themselves. Even one minor version up in GCC produces warnings.
So submitting this to limit -Werror purely to contributors.