Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Frame dropDepends now drops all depend types (#976)
* Frame dropDepends now drops all depend types MenuActions calling frame.dropDepends only drops FRAME_ON_FRAME dependencies, DependDoJdbc query only checks "pk_frame_depend_er" returns empty list if none found. This does not drop any other types of dependencies. Users create complicated dependency types like FRAME_ON_JOB, FRAME_ON_LAYER etc. that don't always have FRAME_ON_FRAME, so this function would fail to drop the dependencies and caused the frame to be "stuck" in Depend state because all depend types need to be satisfied before the frame is allowed to run. Changed loop to getWhatThisDependsOn() and drop them one by one, allowing the frame to go in "Waiting" and ready to run. (cherry picked from commit 9741efe5f21e524e5c0353115da644698a971488) * Cuegui dropDepends unittest uses depends The changes to dropDepends broke the MenuActions unittest, because the fn now calls `getWhatThisDependsOn`, which threw a `'Mock' object is not iterable` error. Needed to add depend object for it to pass. * Change dropDepends unittests for github Cuegui MenuActions_tests.py's test_dropDepends unittest no longer applies since the fn no longer calls the pycue's dropDepends with a target parameter. This is a bug fix to dropDepends and now the fn iterates over each dependency and calls "depend.satisfy" instead to remove since the pycue'sdropDepends only applys to "one" depend target, so it will not remove different multiple different dependency types linked to the one frame. Hence, this caused the Cuegui unittest to fail on the Github PR. Opting to put the dropDepends test in pycue (which didn't have one) and remove the test in Cuegui, since Cuegui already has a test coverage for depend.satisfy.
- Loading branch information