Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number of GPU units in RunningFrameInfo #1017

Merged
merged 1 commit into from Sep 12, 2021
Merged

Fix number of GPU units in RunningFrameInfo #1017

merged 1 commit into from Sep 12, 2021

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Aug 23, 2021

Fix a bug introduced in #924

  • rqnetwork.py numGpus is always 0 馃槥
  • It can just use runFrame.num_gpus.
    • Because this code block is working correctly

      OpenCue/rqd/rqd/rqcore.py

      Lines 865 to 868 in c22fe12

      if runFrame.num_gpus:
      reserveGpus = self.machine.reserveGpus(runFrame.num_gpus)
      if reserveGpus:
      runFrame.attributes['GPU_LIST'] = reserveGpus

bcipriano
bcipriano approved these changes Sep 12, 2021
View reviewed changes
Copy link
Collaborator

@bcipriano bcipriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also makes it consistent with num_cores which is nice 馃憤

@bcipriano bcipriano merged commit 42ffe1f into AcademySoftwareFoundation:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcipriano bcipriano bcipriano approved these changes

@DiegoTavares DiegoTavares Awaiting requested review from DiegoTavares DiegoTavares is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton gregdenton is a code owner

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles IdrisMiles is a code owner

@jrray jrray Awaiting requested review from jrray jrray is a code owner

@larsbijl larsbijl Awaiting requested review from larsbijl larsbijl is a code owner

@smith1511 smith1511 Awaiting requested review from smith1511 smith1511 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splhack @bcipriano