Add new features to Redirect plus revamp existing #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per users' requests changes include: column sorting, new columns LLU and last log line, running cores for a job, increase ProcTime hours, safety checks prior to redirecting so not to kill target frames, indication of redirect completion, ability to select jobs to add to cuetopia, adding max core filter, show job's pending frames, added error handling. Refactored code to follow PEP 8, following predominate casing type and not use mixed casing.
roulaoregan-spi
force-pushed
the
revamp-redirect
branch
4 times, most recently
from
dd4d6ba
to
663d363
Compare
|
Pylint is failing on PySide signal hooks: ************* Module cuegui.Redirect I think it's related to a reported bug: pylint-dev/pylint#2585 |
|
Yeah, pylint has a lot of trouble with those PySide hooks. I haven't found a way to fix it yet. You can disable the |
|
@bcipriano - thanks for your help, I'll look to disable it! |
roulaoregan-spi
force-pushed
the
revamp-redirect
branch
from
663d363
to
ad8e3fc
Compare
roulaoregan-spi
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
DiegoTavares
approved these changes
Apr 8, 2022
bcipriano
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Improve plugin's usability, as per users' requests for the following functionality:
Refactored code to follow PEP 8, following predominate casing type and not use mixed casing.