Convert log paths between OSs #1138
Conversation
As windows job logs are now having their path saved to the database, the GUI needs to be able to convert paths so that multiple OSs can read the logs using the GUI
DiegoTavares
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
IdrisMiles and
splhack
as code owners
|
@bcipriano would you review this? |
| if my_os != job_os and \ | ||
| my_os in cuegui.Constants.LOG_ROOT_OS and \ | ||
| job_os in cuegui.Constants.LOG_ROOT_OS: | ||
| log_dir = log_dir.replace(cuegui.Constants.LOG_ROOT_OS[job_os], |
There was a problem hiding this comment.
Actually it strikes me that replace might cause some unintended changes to the path, depending on what folks are using as their roots. Maybe we could do the substitution using trim?
cuegui/cuegui/Constants.py
Outdated
| LOG_ROOT_OS = { | ||
| "rhel7": "/shots", | ||
| "linux": "/shots", | ||
| "windows": "S:" |
There was a problem hiding this comment.
Might be nice to have a macOS example in here as well.
Still using replace, but only targeting the first occurrence to avoid unintended substitutions Added a macos example
|
So great to see work on this. Would it also be possible to separate the root blades write command logs to from where cuegui reads the logs? In our current farm setup we write logs locally and use filebeat and logstash to get logs to the central location to avoid nfs mounts when scaling to cloud. |
|
@bcipriano your suggestions have been applied. I'm still using replace, but only targeting the first occurrence to avoid unintended substitutions as suggested. |
That makes total sense. Would you mind adding a new feature request for this? |
As windows job logs are now having their path saved to the database (#1133), the
GUI needs to be able to convert paths so that multiple OSs can read the
logs using the GUI.