-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuebot: Make frames and layers readonly after job is done #1164
cuebot: Make frames and layers readonly after job is done #1164
Conversation
4249cf3
to
323007f
Compare
This issue has been discussed on the TSC: To avoid impacting other pipelines where it would make sense to retry frames on finished jobs, this feature should be configurable by a flag on the config file. |
620266c
to
05f6333
Compare
1a797c2
to
d956bdb
Compare
I added a flag to toggle this feature. The default behavior will be allowing the frames/layers be editable even if the flag is not defined. I am hoping that this would make sure it won't break any pipelines. To toggle this feature on, you will have to explicitly add flags for both layer and frame in the prop file. |
d956bdb
to
e6e64c5
Compare
e6e64c5
to
d729ce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few questions.
Link the Issue(s) this Pull Request is related to.
Retrying a frame in a finished job will cause the frame to go back into the waiting state and the job will return to the cue. This even bypasses checks on duplicate job names, so two jobs with the same name can be running at the same time. Hence, it should be disallowed to retry frames on finished jobs, and the finished jobs should be read only.
Summarize your change.
Endpoints that edit layers or frames now check whether or not the job is finished. If it is finished, then an error is returned. This will make sure the job is readonly from cuebot side.