Cuesubmit command feedback

cuesubmit/cuesubmit/Constants.py

@@ -37,8 +37,9 @@
 MAYA_RENDER_CMD = config.get('MAYA_RENDER_CMD', 'Render')
 NUKE_RENDER_CMD = config.get('NUKE_RENDER_CMD', 'nuke')
 BLENDER_RENDER_CMD = config.get('BLENDER_RENDER_CMD', 'blender')
-FRAME_TOKEN = config.get('FRAME_TOKEN', '#IFRAME#')
-
+FRAME_TOKEN = '#IFRAME#'
+FRAME_START = '#FRAME_START#'
+FRAME_END = '#FRAME_END#'
 BLENDER_FORMATS = ['', 'AVIJPEG', 'AVIRAW', 'BMP', 'CINEON', 'DPX', 'EXR', 'HDR', 'IRIS', 'IRIZ',
                    'JP2', 'JPEG', 'MPEG', 'MULTILAYER', 'PNG', 'RAWTGA', 'TGA', 'TIFF']
 BLENDER_OUTPUT_OPTIONS_URL = \

cuesubmit/cuesubmit/Submission.py

@@ -30,25 +30,27 @@
 from cuesubmit import JobTypes
 
 
-def buildMayaCmd(layerData):
+def buildMayaCmd(layerData, silent=False):
     """From a layer, builds a Maya Render command."""
     camera = layerData.cmd.get('camera')
     mayaFile = layerData.cmd.get('mayaFile')
-    if not mayaFile:
+    if not mayaFile and not silent:
         raise ValueError('No Maya File provided. Cannot submit job.')
-    renderCommand = '{renderCmd} -r file -s {frameToken} -e {frameToken}'.format(
-        renderCmd=Constants.MAYA_RENDER_CMD, frameToken=Constants.FRAME_TOKEN)
+    renderCommand = '{renderCmd} -r file -s {frameStart} -e {frameEnd}'.format(
+        renderCmd=Constants.MAYA_RENDER_CMD,
+        frameStart=Constants.FRAME_START,
+        frameEnd=Constants.FRAME_END)
     if camera:
         renderCommand += ' -cam {}'.format(camera)
     renderCommand += ' {}'.format(mayaFile)
     return renderCommand
 
 
-def buildNukeCmd(layerData):
+def buildNukeCmd(layerData, silent=False):
     """From a layer, builds a Nuke Render command."""
     writeNodes = layerData.cmd.get('writeNodes')
     nukeFile = layerData.cmd.get('nukeFile')
-    if not nukeFile:
+    if not nukeFile and not silent:
         raise ValueError('No Nuke file provided. Cannot submit job.')
     renderCommand = '{renderCmd} -F {frameToken} '.format(
         renderCmd=Constants.NUKE_RENDER_CMD, frameToken=Constants.FRAME_TOKEN)
@@ -58,12 +60,12 @@ def buildNukeCmd(layerData):
     return renderCommand
 
 
-def buildBlenderCmd(layerData):
+def buildBlenderCmd(layerData, silent=False):
     """From a layer, builds a Blender render command."""
     blenderFile = layerData.cmd.get('blenderFile')
     outputPath = layerData.cmd.get('outputPath')
     outputFormat = layerData.cmd.get('outputFormat')
-    if not blenderFile:
+    if not blenderFile and not silent:
         raise ValueError('No Blender file provided. Cannot submit job.')
 
     renderCommand = '{renderCmd} -b -noaudio {blenderFile}'.format(
@@ -102,46 +104,31 @@ def buildLayer(layerData, command, lastLayer=None):
             layer.depend_on(lastLayer)
     return layer
 
-
-def buildMayaLayer(layerData, lastLayer):
-    """Builds a PyOutline layer running a Maya command."""
-    mayaCmd = buildMayaCmd(layerData)
-    return buildLayer(layerData, mayaCmd, lastLayer)
-
-
-def buildNukeLayer(layerData, lastLayer):
-    """Builds a PyOutline layer running a Nuke command."""
-    nukeCmd = buildNukeCmd(layerData)
-    return buildLayer(layerData, nukeCmd, lastLayer)
-
-
-def buildBlenderLayer(layerData, lastLayer):
-    """Builds a PyOutline layer running a Blender command."""
-    blenderCmd = buildBlenderCmd(layerData)
-    return buildLayer(layerData, blenderCmd, lastLayer)
-
-
-def buildShellLayer(layerData, lastLayer):
-    """Builds a PyOutline layer running a shell command."""
-    return buildLayer(layerData, layerData.cmd['commandTextBox'], lastLayer)
-
+def buildLayerCommand(layerData, silent=False):
+    """Builds the command to be sent per jobType"""
+    if layerData.layerType == JobTypes.JobTypes.MAYA:
+        command = buildMayaCmd(layerData, silent)
+    elif layerData.layerType == JobTypes.JobTypes.SHELL:
+        command = layerData.cmd.get('commandTextBox') if silent else layerData.cmd['commandTextBox']
+    elif layerData.layerType == JobTypes.JobTypes.NUKE:
+        command = buildNukeCmd(layerData, silent)
+    elif layerData.layerType == JobTypes.JobTypes.BLENDER:
+        command = buildBlenderCmd(layerData, silent)
+    else:
+        if silent:
+            command = 'Error: unrecognized layer type {}'.format(layerData.layerType)
+        else:
+            raise ValueError('unrecognized layer type {}'.format(layerData.layerType))
+    return command
 
 def submitJob(jobData):
     """Submits the job using the PyOutline API."""
     ol = outline.Outline(
         jobData['name'], shot=jobData['shot'], show=jobData['show'], user=jobData['username'])
     lastLayer = None
     for layerData in jobData['layers']:
-        if layerData.layerType == JobTypes.JobTypes.MAYA:
-            layer = buildMayaLayer(layerData, lastLayer)
-        elif layerData.layerType == JobTypes.JobTypes.SHELL:
-            layer = buildShellLayer(layerData, lastLayer)
-        elif layerData.layerType == JobTypes.JobTypes.NUKE:
-            layer = buildNukeLayer(layerData, lastLayer)
-        elif layerData.layerType == JobTypes.JobTypes.BLENDER:
-            layer = buildBlenderLayer(layerData, lastLayer)
-        else:
-            raise ValueError('unrecognized layer type %s' % layerData.layerType)
+        command = buildLayerCommand(layerData)
+        layer = buildLayer(layerData, command, lastLayer)
         ol.add_layer(layer)
         lastLayer = layer
 

cuesubmit/cuesubmit/ui/SettingsWidgets.py

@@ -217,6 +217,7 @@ def setupConnections(self):
         # pylint: disable=no-member
         self.fileInput.lineEdit.textChanged.connect(self.dataChanged.emit)
         self.outputPath.lineEdit.textChanged.connect(self.dataChanged.emit)
+        self.outputSelector.optionsMenu.triggered.connect(self.dataChanged.emit)
         # pylint: enable=no-member
 
     def setCommandData(self, commandData):

cuesubmit/cuesubmit/ui/Style.py

@@ -173,6 +173,15 @@
 }
 """
 
+DISABLED_LINE_EDIT = """
+QLineEdit {
+    color: rgb(110, 110, 110);
+    border: 0px solid;
+    background-color: rgb(30, 35, 40);
+    border-radius: 4px;
+}
+"""
+
 SEPARATOR_LINE = 'border: 1px solid rgb(20, 30, 40)'
 
 TEXT = 'background-color: rgb(40, 50, 60); color: rgb(250, 250, 250); font-weight: regular;'

cuesubmit/cuesubmit/ui/Submit.py

@@ -202,6 +202,8 @@ def __init__(
         self.facilitySelector.setChecked(selected_facility)
 
         self.settingsWidget = self.jobTypes.build(self.primaryWidgetType, *args, **kwargs)
+        self.commandFeedback = Widgets.CueLabelLineEdit( labelText='Final command:' )
+        self.commandFeedback.greyOut()
         self.jobTreeWidget = Job.CueJobWidget()
         self.submitButtons = CueSubmitButtons()
         self.setupUi()
@@ -280,6 +282,7 @@ def setupUi(self):
         self.coresLayout.addWidget(self.dependSelector)
         self.coresLayout.addSpacerItem(Widgets.CueSpacerItem(Widgets.SpacerTypes.HORIZONTAL))
         self.layerInfoLayout.addLayout(self.coresLayout)
+        self.layerInfoLayout.addWidget(self.commandFeedback)
         self.scrollingLayout.addLayout(self.layerInfoLayout)
 
         self.scrollingLayout.addSpacerItem(Widgets.CueSpacerItem(Widgets.SpacerTypes.VERTICAL))
@@ -329,6 +332,7 @@ def jobLayerSelectionChanged(self, layerObject):
         self.dependSelector.clearChecked()
         self.dependSelector.setChecked([layerObject.dependType])
         self.settingsWidget.setCommandData(layerObject.cmd)
+        self.updateFeedbackCommand(layerObject)
         self.skipDataChangedEvent = False
 
     def jobDataChanged(self):
@@ -351,6 +355,13 @@ def jobDataChanged(self):
             dependsOn=None
         )
         self.jobTreeWidget.updateJobData(self.jobNameInput.text())
+        self.updateFeedbackCommand(self.jobTreeWidget.currentLayerData)
+
+    def updateFeedbackCommand(self, layerData):
+        """ Builds the final command for this layer and displays it in the feedback widget """
+        command = Submission.buildLayerCommand(layerData=layerData,
+                                               silent=True)
+        self.commandFeedback.setText(text=command)
 
     def jobTypeChanged(self):
         """Action when the job type is changed."""

cuesubmit/cuesubmit/ui/Widgets.py

@@ -104,6 +104,11 @@ def text(self):
         """
         return self.lineEdit.text()
 
+    def greyOut(self):
+        """Make widget grey and read-only"""
+        self.lineEdit.setReadOnly(True)
+        self.lineEdit.setStyleSheet(Style.DISABLED_LINE_EDIT)
+
 
 class CueLineEdit(QtWidgets.QLineEdit):
     """Wrapper around QLineEdit that allows for changing text with up/down arrow keys."""