Add unit tests for RqMachine. #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdenton
approved these changes
Oct 7, 2019
rqd/rqd/rqmachine.py
Outdated
Comment on lines
557
to
559
| with open(rqconstants.PATH_MEMINFO, "r") as fp: | ||
| meminfoLines = fp.readlines() | ||
| for line in meminfoLines: |
There was a problem hiding this comment.
As a pattern I tend to prefer the following since it doesn't store the entire file in memory (probably not of concern with such a small file):
with open(rqconstants.PATH_MEMINFO) as fp:
for line in fp:
...
There was a problem hiding this comment.
Good point, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#396
Summarize your change.
Coverage up to 82% now in that file.