Add unit tests for cuerqd.py. #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdenton
approved these changes
Oct 12, 2019
| @@ -137,7 +137,7 @@ def killFrame(self, frameId, message): | |||
| self.frameStub.Kill(run_frame=runFrame, message=message) | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| def main(): | |||
There was a problem hiding this comment.
We should probably cleanup this whole bit later on. I added #491 to switch to using something like argparse.
There was a problem hiding this comment.
Agreed. I was tempted to just do it here but decided it's best to get tests in place first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#396
Summarize your change.
Brings file coverage up to 93%, RQD coverage up to 68%.