Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cuegui to create subscriptions larger than 50000 #576

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Allow cuegui to create subscriptions larger than 50000 #576

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
371e09e
increase max size and burst dialog values
Dec 12, 2019
3bbef47
use max int value
Dec 12, 2019
be55d00
Add qt max int constant
Dec 13, 2019
fb1b1e8
Delete unnecessary file
Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 4 additions & 8 deletions cuegui/cuegui/MenuActions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,10 +1136,8 @@ def editSize(self, rpcObjects=None):
body = "Please enter the new subscription size value:\nThis " \
"should only be changed by administrators.\nPlease " \
"contact the resource department."
(value, choice) = QtWidgets.QInputDialog.getDouble(self._caller,
title, body,
current,
0, 50000, 0)
(value, choice) = QtWidgets.QInputDialog.getDouble(self._caller, title, body, current,
0, 2147483647, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to move this numerical value to a constant so it reads easier. Could do the same for the other numbers that get passed here too.

if choice:
msg = QtWidgets.QMessageBox()
msg.setText("You are about to modify a number that can effect a shows billing. Are you in PSR-Resources?")
Expand All @@ -1162,10 +1160,8 @@ def editBurst(self, rpcObjects=None):
title = "Edit Subscription Burst"
body = "Please enter the maximum number of cores that this " \
"subscription should be allowed to reach:"
(value, choice) = QtWidgets.QInputDialog.getDouble(self._caller,
title, body,
current,
0, 50000, 0)
(value, choice) = QtWidgets.QInputDialog.getDouble(self._caller, title, body, current,
0, 2147483647, 0)
if choice:
for sub in subs:
self.cuebotCall(sub.setBurst,
Expand Down