-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix filter alignment in monitor host panel #675
fix filter alignment in monitor host panel #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question.
cuegui/cuegui/HostMonitor.py
Outdated
@@ -122,6 +122,7 @@ def __filterAllocationSetup(self, layout): | |||
|
|||
btn = QtWidgets.QPushButton("Filter Allocation") | |||
btn.setMaximumHeight(FILTER_HEIGHT) | |||
btn.setStyleSheet(" width: 120px;"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could find a way for this to be adaptive to the text contained within the button, so for example if the button's text grows the button will grow with it.
For example, could we set button's padding
instead of setting an explicit size?
If so, can we set this in the stylesheet (darkpalette.qss
) so it fixes this for ALL buttons, instead of just these two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, that definetly sounds better.
Will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcipriano Updated the PR. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, nice improvement! Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks.
LGTM.
Fixes #672 by properly aligning the dropdown arrows with the text in Allocation and HardwareState filter in monitor hosts panel in CueGUI.