-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add timeout and LLU timeout #761
feat: Add timeout and LLU timeout #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I think we'll just need to clean up the comments around versioning to make it clear that upgrading here will cause some incompatibility and needs some extra care.
0b961a7
to
b039b02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. Just need to resolve the conflicts here and we'll be ready to merge.
Add support for layers to have timeout. If a frame goes past it's hard timeout it get's killed. LLU timeout is usually a lower value that check when the last log update has happend. if no update happens in the LLU window it's also killed. Closes AcademySoftwareFoundation#462
b039b02
to
6a965d6
Compare
Done |
@bcipriano this should be ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Add support for layers to have timeout.
If a frame goes past it's hard timeout it get's killed.
LLU timeout is usually a lower value that check when the last log
update has happend. if no update happens in the LLU window it's also
killed.
Closes #462