Add subscription graph #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsbijl
requested review from
bcipriano,
DiegoTavares,
gregdenton,
jrray and
smith1511
as code owners
bcipriano
reviewed
Dec 9, 2020
| @@ -0,0 +1,216 @@ | |||
| import sys # We need sys so that we can pass argv to QApplication | |||
There was a problem hiding this comment.
Could you explain more about how this works? Kind of weird to see it imported but not actually used anywhere in the file.
There was a problem hiding this comment.
doesn't sound right. I'll remove it as I can't see a reason for it.
Display a job's usage's using the bar chart. Closes AcademySoftwareFoundation#838
larsbijl
force-pushed
the
838-subscription-graph
branch
from
58f3247
to
a7996f0
Compare
|
@larsbijl Merge conflict here as well. Ready to merge other than that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a job's usage's using the bar chart.
Closes #838