-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support #845
Add IPv6 support #845
Conversation
Hi, I have a question about Corporate CLA. https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/tsc/ccla.md
-- |
Added unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually I forgot one small thing -- this PR changes the database schema so we need to do a minor version bump -- update VERSION.in
at the root level of the repository to 0.4
-> 0.5
.
@bcipriano sure, done 🙂 |
This PR is addressing IPv6-only hosting for RQD machines.
Issue
gethostbyname
.Solution
getaddrinfo
whenRQD_USE_IPV6_AS_HOSTNAME
config variable isTrue
.30
to45
in the database schema.45
is defined by POSIX,INET6_ADDRSTRLEN
(which is46
==45
+NULL
.)