-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RQD_TAGS #916
Fix RQD_TAGS #916
Conversation
Skipped the unittests on CY2019 CI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Change looks good, but I've merged #911 now so could you merge master on your branch to make sure we have a clean diff?
67855c2
to
31c7ec6
Compare
@bcipriano sure, I've just rebased. |
Thanks, change LGTM. What was the test failure under Python 2? I don't see it listed here. Maybe I can point you in the right direction -- would love to avoid disabling it if we can. |
34ec013
to
908d609
Compare
CY2019 (Python 2.7.15) looks like failed to read config file,
|
oh, ok, so, the cause is CY2019 doesn't have
|
progress. But |
8414874
to
95868c1
Compare
ok, added the same treatment as PyOutline OpenCue/pyoutline/outline/config.py Lines 35 to 41 in 70e4776
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one last question.
requirements.txt
Outdated
@@ -1,4 +1,5 @@ | |||
2to3==1.0 | |||
configparser==4.0.2;python_version<"3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If configparser
is coming from the six
library now, do we still need this new dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess not. deleted.
95868c1
to
2fb1197
Compare
RQD_TAGS
didn't work due to the method (getint
vsget
) in the first place 😅Added unit tests with mocking rqd.conf