-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MonitorCue displays all jobs/groups to move #979
Merged
bcipriano
merged 12 commits into
AcademySoftwareFoundation:master
from
roulaoregan-spi:fix-move-job-window-cutoff
May 11, 2022
Merged
MonitorCue displays all jobs/groups to move #979
bcipriano
merged 12 commits into
AcademySoftwareFoundation:master
from
roulaoregan-spi:fix-move-job-window-cutoff
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b4b936
to
e258c22
Compare
6ed1d25
to
2a6ce67
Compare
When moving a lot of jobs to a different cue group, the confirmation popup cuts off at the bottom, changed to an exapandable dialog with a scrollbar to allow user to view large number of jobs.
2a6ce67
to
a01349e
Compare
Unittests were failing due to using the old style API, causing pylint error: `Method 'clicked' has no 'connect' member (no-member)`. Change signal call to use the style to help fix this error.
When moving a lot of jobs to a different cue group, the confirmation popup cuts off at the bottom, changed to an exapandable dialog with a scrollbar to allow user to view large number of jobs.
Unittests were failing due to using the old style API, causing pylint error: `Method 'clicked' has no 'connect' member (no-member)`. Change signal call to use the style to help fix this error.
…roregan/OpenCue into fix-move-job-window-cutoff
86c30b4
to
898db17
Compare
When moving a lot of jobs to a different cue group, the confirmation popup cuts off at the bottom, changed to an exapandable dialog with a scrollbar to allow user to view large number of jobs.
Unittests were failing due to using the old style API, causing pylint error: `Method 'clicked' has no 'connect' member (no-member)`. Change signal call to use the style to help fix this error.
When moving a lot of jobs to a different cue group, the confirmation popup cuts off at the bottom, changed to an exapandable dialog with a scrollbar to allow user to view large number of jobs.
bcipriano
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
When moving a lot of jobs to a different cue group, the confirmation popup cuts off at the bottom, changed to an expandable dialog with a scrollbar to allow user to view large number of jobs.