Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] the link to test images in the install.md is broken #4042

Closed
benroeder opened this issue Nov 1, 2023 · 0 comments · Fixed by #4080
Closed

[BUG] the link to test images in the install.md is broken #4042

benroeder opened this issue Nov 1, 2023 · 0 comments · Fixed by #4080

Comments

@benroeder
Copy link

I spent an hour going through the process of submitting patch got stuck at dso gate, and its only a one line fix to the markdown

Describe the bug

The link * http://www.openexr.com/downloads.html is broken and 404's

To Reproduce

click link

Expected behavior
Screenshot 2023-11-01 at 12 41 01

should link here

Evidence
Screenshot 2023-11-01 at 12 39 57

Platform information:

  • OIIO branch/version:
  • OS:
  • C++ compiler:
  • Any non-default build flags when you build OIIO:

IF YOU ALREADY HAVE A CODE FIX: There is no need to file a separate issue,
please just go straight to making a pull request.

lgritz pushed a commit that referenced this issue Dec 22, 2023
## Description

Minimal change to update link to OpenEXR's new Test Images page. I poked
around a bit to find a "friendlier" variant of the link but could find
none.

Note that the section containing this link implies that folks need to
download these files themselves and should be "placed in a sibling
directory to oiio-testimages". The problem is that not even OpenEXR
lists the repository for the test images nor does the page linked above
offer a download.

Should we list out the openexr-images repo address too and say to just
clone that?

Fixes #4042

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
lgritz pushed a commit to lgritz/OpenImageIO that referenced this issue Dec 24, 2023
## Description

Minimal change to update link to OpenEXR's new Test Images page. I poked
around a bit to find a "friendlier" variant of the link but could find
none.

Note that the section containing this link implies that folks need to
download these files themselves and should be "placed in a sibling
directory to oiio-testimages". The problem is that not even OpenEXR
lists the repository for the test images nor does the page linked above
offer a download.

Should we list out the openexr-images repo address too and say to just
clone that?

Fixes AcademySoftwareFoundation#4042

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
1div0 pushed a commit to 1div0/OpenImageIO that referenced this issue Feb 24, 2024
## Description

Minimal change to update link to OpenEXR's new Test Images page. I poked
around a bit to find a "friendlier" variant of the link but could find
none.

Note that the section containing this link implies that folks need to
download these files themselves and should be "placed in a sibling
directory to oiio-testimages". The problem is that not even OpenEXR
lists the repository for the test images nor does the page linked above
offer a download.

Should we list out the openexr-images repo address too and say to just
clone that?

Fixes AcademySoftwareFoundation#4042

---------

Signed-off-by: Jesse Yurkovich <jesse.y@gmail.com>
Signed-off-by: Peter Kovář <peter.kovar@reflexion.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant