Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seg fault at initalization in debug mode #1573

Merged
merged 1 commit into from Dec 1, 2016
Merged

Fix seg fault at initalization in debug mode #1573

merged 1 commit into from Dec 1, 2016

Commits on Dec 1, 2016

  1. Fix seg fault at initalization in debug mode 

    When using gcc 4.8 on centos7, with debug compile, in a certain app, we
get core dumps involving SIGSEGV in __memcmp_sse4_1 deep inside
operator[](std::string&&).

We suspect it's the old "initialization order fiasco." Wrapping the tag
table as a static within a function that returns its reference seems to
fix things. I also switched from strings to string_view for the table
keys.
    @lgritz
    J Robert Ray authored and lgritz committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    37da7ba View commit details
    Browse the repository at this point in the history