OpenEXR: ensure that "YA" images get channels presented in the right order #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…order. Background: OpenEXR forces channels to be stored (or at least presents it through its API) in strictly alphabetical order. But OIIO expects uniform channel orders for all the common cases such as RGBA. For a 2-channel image that's intensity and alpha, we name the channels "Y" and "A", and expect it to be presented with alpha second, as usual. But OpenEXR was flipping the channel order because "A" comes before "Y" alphabetically. Sheesh. It was because we neglected to put "Y" in the list of special channel names that have order imposed. Easy fix.
|
Looks good to me and solves the problem I saw with Y,A textures and TextureSys. |
|
Great, thanks for checking. I'll merge. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 15, 2017
…order. (AcademySoftwareFoundation#1717) Background: OpenEXR forces channels to be stored (or at least presents it through its API) in strictly alphabetical order. But OIIO expects uniform channel orders for all the common cases such as RGBA. For a 2-channel image that's intensity and alpha, we name the channels "Y" and "A", and expect it to be presented with alpha second, as usual. But OpenEXR was flipping the channel order because "A" comes before "Y" alphabetically. Sheesh. It was because we neglected to put "Y" in the list of special channel names that have order imposed. Easy fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: OpenEXR forces channels to be stored (or at least presents
it through its API) in strictly alphabetical order. But OIIO expects
uniform channel orders for all the common cases such as RGBA.
For a 2-channel image that's intensity and alpha, we name the channels
"Y" and "A", and expect it to be presented with alpha second, as usual.
But OpenEXR was flipping the channel order because "A" comes before "Y"
alphabetically. Sheesh. It was because we neglected to put "Y" in the
list of special channel names that have order imposed. Easy fix.