oiio: fixed move constructor of ParamValue class. #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this bugfix is an important one. I don't know how ParamValue could have worked before. |
lgritz
reviewed
Aug 8, 2017
| @@ -117,6 +117,7 @@ class OIIO_API ParamValue { | |||
| : m_name(p.m_name), m_nvalues(p.m_nvalues), m_interp(p.m_interp), | |||
There was a problem hiding this comment.
Let's put it here, where the other initializers are (except for the ones that are part of unions, which is harder to do in the initializer list).
|
LGTM. Good catch! I suspect that it went unnoticed because it's the "move" constructor, and the reliance on this C++11 feature is relatively new for us? But yeah, surprised it hasn't made noticeable bugs before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ParamValue move constructor was not copying the internal ParamValue type.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).