oiio/RB-1.7: Use GNUInstallDirs for installation paths #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all hard coded paths to GNUInstallDirs varibles. Remove variable setting in main CMakeFiles.txt file since GNUInstallDirs does all this for you. Signed-off by: Jonathan Scruggs <j.scruggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all hard coded paths to GNUInstallDirs varibles.
Remove variable setting in main CMakeFiles.txt file since
GNUInstallDirs does all this for you.
Signed-off by: Jonathan Scruggs j.scruggs@gmail.com
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).
As discussed in the similar PR from OpenShadingLanuage. I can sign the CLA as needed.
The new Python install directory code is just my attempt at a single variable to hold the install path. The idea was to show how GNUInstallDirs can be used for the path. You may be able to think of a better way. None of the prefixing needs to be done that the old way has since those prefixes are set by CMake, even the exec ones. Let me know your thoughts and I can update this accordingly.
I can't test the python module as the boost-python libs are not being found. There was this issue with another program that we fixed, but I can't remember how. I'll look at the detection code later. This has nothing to do with the new install path code I have, but the detection routines. This was always an issue with OpenImageIO.