Fix IBA::fillholes_pushpull when display window != data window #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pasted the result into the dest to be aligned with the dst's data origin, instead of the correct source origin. While I was there, I slightly simplified the error checking by using existing IBAPrep functionality to check for the same edge cases.
lgritz
commented
Sep 15, 2017
| @@ -1098,7 +1084,7 @@ ImageBufAlgo::fillholes_pushpull (ImageBuf &dst, const ImageBuf &src, | |||
|
|
|||
| // Now copy the completed base layer of the pyramid back to the | |||
| // original requested output. | |||
| paste (dst, dstspec.x, dstspec.y, dstspec.z, 0, *pyramid[0]); | |||
| paste (dst, src.spec().x, src.spec().y, src.spec().z, 0, *pyramid[0]); | |||
There was a problem hiding this comment.
This line is the actual bug fix. The rest is just cleanup, testing, and docs clarification.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pasted the result into the dest to be aligned with the dst's data
origin, instead of the correct source origin. So for cropped, overscanned,
or shrink-wrapped images, it would botch the origin.
While I was there, I slightly simplified the error checking by using
existing IBAPrep functionality to check for the same edge cases.