Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect simd.h against stray #define of True or False #2272

Merged
merged 1 commit into from Jun 27, 2019
Merged

Protect simd.h against stray #define of True or False #2272

merged 1 commit into from Jun 27, 2019

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jun 27, 2019

This proposed patch just #undef's it.

Optionally, I could also re-define it at the end, like:

#ifdef _X11_XLIB_H_ /* regrettable */
    #define True 1
    #define False 1
#endif

I'm not sure if that's clever, or "too clever" and will cause more trouble.

@fpsunflower
Copy link
Contributor

Redefining seems like trouble for anyone who would want to use vbool*::True down the line.

LGTM!

@lgritz lgritz merged commit 9dcde4e into AcademySoftwareFoundation:master Jun 27, 2019
@lgritz lgritz deleted the lg-simd branch June 27, 2019 23:26
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Jun 27, 2019
@lgritz
Protect simd.h against stray #define of True or False (AcademySoftwar…
0ffdfdc 
…eFoundation#2272)
lgritz added a commit to lgritz/OpenImageIO that referenced this pull request Jun 28, 2019
@lgritz
Protect simd.h against stray #define of True or False (AcademySoftwar…
e78be15 
…eFoundation#2272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lgritz @fpsunflower